[webkit-reviews] review denied: [Bug 111854] Making more sophisticated cache flush on ARM Linux platform : [Attachment 192231] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 05:05:39 PDT 2013


Zoltan Herczeg <zherczeg at webkit.org> has denied Gabor Rapcsanyi
<rgabor at webkit.org>'s request for review:
Bug 111854: Making more sophisticated cache flush on ARM Linux platform
https://bugs.webkit.org/show_bug.cgi?id=111854

Attachment 192231: proposed patch
https://bugs.webkit.org/attachment.cgi?id=192231&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
Nice patch, but:

View in context: https://bugs.webkit.org/attachment.cgi?id=192231&action=review


> Source/JavaScriptCore/assembler/ARMAssembler.h:1060
> +	       for (current = firstPageEnd; current < end; current +=
pageSize())

I think this is incorrect. Are you sure it is not "current + pageSize() < end"?


More information about the webkit-reviews mailing list