[webkit-reviews] review denied: [Bug 96592] Ruby text is incorrectly positioned when its writing-mode is changed to vertical after layout is done : [Attachment 191920] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 96592: Ruby text is incorrectly positioned when its writing-mode is changed
to vertical after layout is done
https://bugs.webkit.org/show_bug.cgi?id=96592

Attachment 191920: Patch
https://bugs.webkit.org/attachment.cgi?id=191920&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191920&action=review


The code looks good. ChangeLog needs a bit polish.

> Source/WebCore/ChangeLog:8
> +	   Fix logical left of RenderRubyText is not cleared.

s/Fix/Fixed/ - WebKit usually uses past tense here.

> Source/WebCore/ChangeLog:10
> +	   This cause trouble when RenderRubyTest is laid out as vertical after
as horizontal.

s/causes/
s/as vertical/vertically/
s/as horizontal/horizontally/

> Source/WebCore/ChangeLog:13
> +	   RenderRubyText::y remain old one.

You should explain not only what the problem was, but also how you fixed it.

> LayoutTests/ChangeLog:8
> +	   Add a test that change block flow direction of Ruby after layout.

You don't need any extra description in this case. This is kinda obvious.