[webkit-reviews] review granted: [Bug 110952] Implement inert subtrees needed for modal <dialog> : [Attachment 192181] add test cases for non-modal and non-open dialogs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 10 20:49:07 PDT 2013


Hajime Morrita <morrita at google.com> has granted Matt Falkenhagen
<falken at chromium.org>'s request for review:
Bug 110952: Implement inert subtrees needed for modal <dialog>
https://bugs.webkit.org/show_bug.cgi?id=110952

Attachment 192181: add test cases for non-modal and non-open dialogs
https://bugs.webkit.org/attachment.cgi?id=192181&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
I'm a bit worrying about the perf implication of this change since this makes
disabled() slower.
But I'm not sure if there are good test to cover such scenarios. disabled()
might not called that much,
after all.

Let's land this and see how graphs react.


More information about the webkit-reviews mailing list