[webkit-reviews] review granted: [Bug 111932]=?UTF-8?Q?=20Add=20a=20heuristic=20to=20determine=20the=20=E2=80=9Cprimary=E2=80=9D=20snapshotted=20plugin=20?=: [Attachment 192367] patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 111932: Add a heuristic to determine the “primary” snapshotted plugin
https://bugs.webkit.org/show_bug.cgi?id=111932

Attachment 192367: patch
https://bugs.webkit.org/attachment.cgi?id=192367&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192367&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3953
> +	       LayoutUnit contentArea = renderBox->contentWidth() *
renderBox->contentHeight();
> +
> +	       if (renderBox->contentWidth() <
primarySnapshottedPlugInMinimumWidth || renderBox->contentHeight() <
primarySnapshottedPlugInMinimumHeight)
> +		   continue;

You can swap these two statements.