[webkit-reviews] review denied: [Bug 110614] [GTK][WK2] Add document-loaded signal to WebKitWebPage : [Attachment 191698] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 110614: [GTK][WK2] Add document-loaded signal to WebKitWebPage
https://bugs.webkit.org/show_bug.cgi?id=110614

Attachment 191698: Patch
https://bugs.webkit.org/attachment.cgi?id=191698&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191698&action=review


Found a small issue, see below.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:52
> +    g_signal_emit(WEBKIT_WEB_PAGE(clientInfo), signals[DOCUMENT_LOADED], 0);


Add an early return here if this it not the main frame, we only want to emit
this signal for the main frame.