[webkit-reviews] review denied: [Bug 111923] Don't create multiple user gesture indicators when forwarding events to sub frames : [Attachment 192347] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied jochen at chromium.org's request for
review:
Bug 111923: Don't create multiple user gesture indicators when forwarding
events to sub frames
https://bugs.webkit.org/show_bug.cgi?id=111923

Attachment 192347: Patch
https://bugs.webkit.org/attachment.cgi?id=192347&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192347&action=review


> Source/WebCore/page/EventHandler.cpp:3169
> +    OwnPtr<UserGestureIndicator> gestureIndicator;
> +
> +    if (!UserGestureIndicator::processingUserGesture())
> +	   gestureIndicator = adoptPtr(new
UserGestureIndicator(DefinitelyProcessingUserGesture));

Why doesn't UserGestureIndicator do this work for us?  If we're already
processing a user gesture, perhaps the UserGestureIndicator shouldn't bump the
count in the token...  Maybe that should be an option in the constructor?