[webkit-reviews] review denied: [Bug 111913] [chromium] Helper Plugin does not have a URL for its Document : [Attachment 192325] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied David Dorwin <ddorwin at chromium.org>'s
request for review:
Bug 111913: [chromium] Helper Plugin does not have a URL for its Document
https://bugs.webkit.org/show_bug.cgi?id=111913

Attachment 192325: Patch
https://bugs.webkit.org/attachment.cgi?id=192325&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192325&action=review


> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:67
> +    // Give the new document the same URL as the hose frame so that content
> +    // settings and other decisions can be made based on the correct origin.

> +    const WebURL& hostFrameURL = hostFrame->document().url();

Why do we pass in a hostFrame instead of a hostDocument?

> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:71
> +    writer.begin(hostFrameURL);

Frames don't have URLs.  Documents have URLs.

> Source/WebKit/chromium/src/WebViewImpl.cpp:168
> +
> +

These changes look spurious.