[webkit-reviews] review denied: [Bug 110263] Add the default video poster if it doesn't exist in video tag : [Attachment 192167] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied michaelbai at chromium.org's request for
review:
Bug 110263: Add the default video poster if it doesn't exist in video tag
https://bugs.webkit.org/show_bug.cgi?id=110263

Attachment 192167: Patch
https://bugs.webkit.org/attachment.cgi?id=192167&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192167&action=review


Looks OK, but breaks whitespace handling in video element poster URLs. I’m
surprised there was no test for this that is broken. Please fix that.

> Source/WebCore/html/HTMLVideoElement.cpp:312
> +    const AtomicString& url = imageSourceURL();

It’s a shame to make a virtual function call here. No big deal, but not ideal
either.

> Source/WebCore/html/HTMLVideoElement.cpp:315
> +    if (url.isEmpty())
> +	   return KURL();
> +    return document()->completeURL(url);

This is missing a call to stripLeadingAndTrailingHTMLSpaces.