[webkit-reviews] review granted: [Bug 110547] Free up background parser's checkpoints when speculation succeeds : [Attachment 192294] Hopefully addressed Adam's concerns

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 15:18:36 PST 2013


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 110547: Free up background parser's checkpoints when speculation succeeds
https://bugs.webkit.org/show_bug.cgi?id=110547

Attachment 192294: Hopefully addressed Adam's concerns
https://bugs.webkit.org/attachment.cgi?id=192294&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192294&action=review


I can't tell if you changed HTMLDocumentParser::pumpPendingSpeculations or if
I've just read it enough times to understand what it's doing.  :)

> Source/WebCore/html/parser/BackgroundHTMLInputStream.h:72
> +    // Note: These indicies may === vector.size(), in which case there are
no valid checkpoints/segments at this time.

===   ->    ==

(Triple-equals is JavaScript silliness.)


More information about the webkit-reviews mailing list