[webkit-reviews] review granted: [Bug 111780] Check to ensure MultisampleRenderbuffer creation succeeds : [Attachment 192291] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 15:02:49 PST 2013


Dean Jackson <dino at apple.com> has granted Brandon Jones
<bajones at chromium.org>'s request for review:
Bug 111780: Check to ensure MultisampleRenderbuffer creation succeeds
https://bugs.webkit.org/show_bug.cgi?id=111780

Attachment 192291: Patch
https://bugs.webkit.org/attachment.cgi?id=192291&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192291&action=review


> Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp:193
> +// TODO(bajones): This can be removed once renderbufferStorageMultisample
starts reporting GL_OUT_OF_MEMORY properly.

We don't normally use names in comments, and WebKit tends to use "FIXME:"
rather than TODO.


More information about the webkit-reviews mailing list