[webkit-reviews] review denied: [Bug 111871] Cleanup of DFG and Baseline JIT debugging code : [Attachment 192260] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 111871: Cleanup of DFG and Baseline JIT debugging code
https://bugs.webkit.org/show_bug.cgi?id=111871

Attachment 192260: Patch
https://bugs.webkit.org/attachment.cgi?id=192260&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192260&action=review


> Source/JavaScriptCore/dfg/DFGOperations.cpp:1634
> -	   double value = *reinterpret_cast_ptr<double*>(scratchPointer);
> +	   double value = static_cast<double>(bits);

Should fix the scratch buffer to allocate 8-byte aligned.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1124
> +	   case DataFormatOSRMarker:
> +	   case DataFormatDead:
> +	   case DataFormatArguments:

These should be RELEASE_ASSERT_NOT_REACHED().

> Source/JavaScriptCore/jit/JITCall32_64.cpp:340
> -		   toCString(*calleeCodeBlock).data())),
> +		   calleeCodeBlock ? toCString(*calleeCodeBlock).data() :
"Null")),

Can also be written as: toCString(PointerDump(calleeCodeBlock)).data()

>> Source/JavaScriptCore/jit/JITCall.cpp:260
>> -		    toCString(*calleeCodeBlock).data())),
>> +		 calleeCodeBlock ? toCString(*calleeCodeBlock).data() :
"Null")),
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]

Ditto