[webkit-reviews] review denied: [Bug 103128] LLInt C Loop backend should work on 32 bit platforms, both big and little endian : [Attachment 183151] make LLInt C Loop backend work on 32 bit platforms, little and big endian

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Tobias Netzel
<tobias.netzel at googlemail.com>'s request for review:
Bug 103128: LLInt C Loop backend should work on 32 bit platforms, both big and
little endian
https://bugs.webkit.org/show_bug.cgi?id=103128

Attachment 183151: make LLInt C Loop backend work on 32 bit platforms, little
and big endian
https://bugs.webkit.org/attachment.cgi?id=183151&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183151&action=review


I recommend adding to LowLevelInterpreter.asm the following:

if JSVALUE64
    const CellOffset = 0
else
    const CellOffset = PayloadOffset
end

And then use CellOffset instead of PayloadOffset in the places that I marked.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:266
> +    loadp Callee + PayloadOffset[cfr], targetRegister

This will break 64-bit big endian.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:272
> +    loadp Callee + PayloadOffset[cfr], targetRegister

This will break 64-bit big endian.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:844
> +    loadp ScopeChain + PayloadOffset[cfr], t3

This will break 64-bit big endian.