[webkit-reviews] review granted: [Bug 111881] Build fix: guard macro test for MAC platform for a feature : [Attachment 192261] Only test for OSX version if the platform is Mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 11:56:05 PST 2013


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Adenilson Cavalcanti
Silva <savagobr at yahoo.com>'s request for review:
Bug 111881: Build fix: guard macro test for MAC platform for a feature
https://bugs.webkit.org/show_bug.cgi?id=111881

Attachment 192261: Only test for OSX version if the platform is Mac
https://bugs.webkit.org/attachment.cgi?id=192261&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192261&action=review


r=me with that change.

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:70
> +#if PLATFORM(MAC)
>  #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080

Usually we just use:

#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080


More information about the webkit-reviews mailing list