[webkit-reviews] review granted: [Bug 111250] AtomicHTMLToken should not be heap allocated or RefCounted : [Attachment 192173] Remove infinity mallocs from parsing

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 111250: AtomicHTMLToken should not be heap allocated or RefCounted
https://bugs.webkit.org/show_bug.cgi?id=111250

Attachment 192173: Remove infinity mallocs from parsing
https://bugs.webkit.org/attachment.cgi?id=192173&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192173&action=review


> Source/WebCore/html/parser/HTMLStackItem.h:227
> +	   , m_tokenAttributes(token->attributes())

If we were clever, we could probably swap the attributes in and out of this
Vector.

> Source/WebCore/html/parser/HTMLStackItem.h:237
> +    AtomicString m_tokenLocalName;
> +    Vector<Attribute> m_tokenAttributes;
>      AtomicString m_namespaceURI;

The names m_tokenLocalName and m_namespaceURI aren't quite symmetric.  Maybe
they're different subtly?