[webkit-reviews] review granted: [Bug 111826] RenderTextControlSingleLine should not assume that its text element has a renderer : [Attachment 192161] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 10:07:10 PST 2013


Ojan Vafai <ojan at chromium.org> has granted Dominic Cooney
<dominicc at chromium.org>'s request for review:
Bug 111826: RenderTextControlSingleLine should not assume that its text element
has a renderer
https://bugs.webkit.org/show_bug.cgi?id=111826

Attachment 192161: Patch
https://bugs.webkit.org/attachment.cgi?id=192161&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192161&action=review


> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:176
> +	   ASSERT(innerTextRenderer);

Having a placeholderBox always means you'll also have a innerTextRenderer?


More information about the webkit-reviews mailing list