[webkit-reviews] review granted: [Bug 53186] @media queries do not take zooming into account : [Attachment 192234] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 09:11:36 PST 2013


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted John Mellor
<johnme at chromium.org>'s request for review:
Bug 53186: @media queries do not take zooming into account
https://bugs.webkit.org/show_bug.cgi?id=53186

Attachment 192234: Patch
https://bugs.webkit.org/attachment.cgi?id=192234&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192234&action=review


> Source/WebCore/ChangeLog:11
> +	   Fixes @media width and height to take into account full page zoom,
by
> +	   adding code to MediaQueryEvaluator's width/heightMediaFeatureEval,
> +	   corresponding to the existing code in Element::clientWidth which
makes
> +	   document.documentElement.clientWidth take into account page zoom.

OK, so this is only full page zoom, and thus not scaling (pinch zoom).


More information about the webkit-reviews mailing list