[webkit-reviews] review granted: [Bug 108213] [Qt] HTML5 video - sound volume bar out of widget : [Attachment 188914] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 04:59:43 PST 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 108213: [Qt] HTML5 video - sound volume bar out of widget
https://bugs.webkit.org/show_bug.cgi?id=108213

Attachment 188914: Patch
https://bugs.webkit.org/attachment.cgi?id=188914&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188914&action=review


I can't say that those coordinates all makes sense to me, but I tested the
patch and it's definitely an improvement.

> Source/WebCore/css/mediaControlsQt.css:39
>      bottom: 0px;

This line is already in mediaControls.css, you should be able to remove it.


More information about the webkit-reviews mailing list