[webkit-reviews] review requested: [Bug 95373] Clickable area is incorrect for elements with border-radius : [Attachment 192139] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 7 21:05:06 PST 2013
Xidorn Quan <quanxunzhen at gmail.com> has asked for review:
Bug 95373: Clickable area is incorrect for elements with border-radius
https://bugs.webkit.org/show_bug.cgi?id=95373
Attachment 192139: patch
https://bugs.webkit.org/attachment.cgi?id=192139&action=review
------- Additional Comments from Xidorn Quan <quanxunzhen at gmail.com>
According to Simon Fraser's suggestion, I moved some of the code into
RoundedRect.cpp and FloatQuad.cpp so that it will be reusable.
I tried to move the function lineIntersectsCircle to the new separate file
mentioned by Simon, but I failed to do that because I am not familiar with the
build system of WebKit, and cannot get the new file to be compiled. If you can
give some hint, I would still like to create the new file.
More information about the webkit-reviews
mailing list