[webkit-reviews] review granted: [Bug 111631] Regression: WebPageProxy::exceededDatabaseQuota() needs to be serialized : [Attachment 192065] updated patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 17:20:13 PST 2013


Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 111631: Regression: WebPageProxy::exceededDatabaseQuota() needs to be
serialized
https://bugs.webkit.org/show_bug.cgi?id=111631

Attachment 192065: updated patch.
https://bugs.webkit.org/attachment.cgi?id=192065&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192065&action=review


r=me with the changes you mentioned.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:175
> +PassOwnPtr<ExceededDatabaseQuotaRecords::Record>
ExceededDatabaseQuotaRecords::createRecord(

Usually we put the 'create' function inside the class. In this case, it would
be Record::create.


More information about the webkit-reviews mailing list