[webkit-reviews] review granted: [Bug 111782] REGRESSION (r143643): <button> should support ::first-line and ::first-letter : [Attachment 192096] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 7 16:58:22 PST 2013
Ojan Vafai <ojan at chromium.org> has granted Christian Biesinger
<cbiesinger at chromium.org>'s request for review:
Bug 111782: REGRESSION (r143643): <button> should support ::first-line and
::first-letter
https://bugs.webkit.org/show_bug.cgi?id=111782
Attachment 192096: Patch
https://bugs.webkit.org/attachment.cgi?id=192096&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192096&action=review
> Source/WebCore/rendering/RenderBlock.cpp:6496
> + if (firstLineBlock->isReplaced() || firstLineBlock->isFloating()
How about a FIXME to remove the isRenderButton check once we support
align-items on RenderBlock and migrate RenderButton off of RenderFlexibleBox?
> Source/WebCore/rendering/RenderBlock.cpp:6550
> + !parentBlock->isBlockFlow() || (parentBlock->isFlexibleBox() &&
!parentBlock->isRenderButton()))
ditto
More information about the webkit-reviews
mailing list