[webkit-reviews] review granted: [Bug 111775] RenderFullScreen needs to clear override sizes when exiting full screen : [Attachment 192090] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 16:56:20 PST 2013


Ojan Vafai <ojan at chromium.org> has granted Christian Biesinger
<cbiesinger at chromium.org>'s request for review:
Bug 111775: RenderFullScreen needs to clear override sizes when exiting full
screen
https://bugs.webkit.org/show_bug.cgi?id=111775

Attachment 192090: Patch
https://bugs.webkit.org/attachment.cgi?id=192090&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192090&action=review


> LayoutTests/fullscreen/full-screen-with-flex-item.html:14
> +  <div><div class=vertical>This div becomes a stretched flex item in
fullscreen mode, and should

Instead of putting a bunch of text, how about you put two or three
display:inline-block divs that each have a height of 500px? Makes the test a
bit simpler to grok.


More information about the webkit-reviews mailing list