[webkit-reviews] review granted: [Bug 111679] Need API to draw custom overhang area : [Attachment 192093] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 111679: Need API to draw custom overhang area
https://bugs.webkit.org/show_bug.cgi?id=111679

Attachment 192093: Patch
https://bugs.webkit.org/attachment.cgi?id=192093&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192093&action=review


r+ but I'd like to see the position/anchor point stuff resolved.

> Source/WebCore/page/FrameView.cpp:871
> +    return
renderView->compositor()->updateLayerForTopOverhangArea(wantsLayer);

This should be #ifdeffed for ACCELERATED_COMPOSITING, and even then probably
with a null-check on the compositor.

> Source/WebCore/page/FrameView.cpp:879
> +    return
renderView->compositor()->updateLayerForBottomOverhangArea(wantsLayer);

Ditto.

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:796
> +    layer->setPosition(FloatPoint(0, -image->size().height()));

If you set the anchor point to (0,1) then the position here should be (0,0)