[webkit-reviews] review granted: [Bug 111515] Intrinsic width keyword values don't work for tables : [Attachment 192057] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 14:58:06 PST 2013


Julien Chaffraix <jchaffraix at webkit.org> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 111515: Intrinsic width keyword values don't work for tables
https://bugs.webkit.org/show_bug.cgi?id=111515

Attachment 192057: Patch
https://bugs.webkit.org/attachment.cgi?id=192057&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192057&action=review


> Source/WebCore/rendering/RenderTable.cpp:317
> +	   return computeIntrinsicLogicalWidthUsing(styleLogicalWidth,
availableWidth, bordersPaddingAndSpacingInRowDirection());

It's suspicious that you add the horizontal border-spacing here, but the
results are correct so I am not going to argue.

> LayoutTests/fast/css-intrinsic-dimensions/tables.html:66
> +	   <td>

Could it be possible to test the cell value in this case?

> LayoutTests/fast/css-intrinsic-dimensions/tables.html:121
> +	   <td>

And here (basically when we grow above the cell's maximum width). It may be
valuable to dump the border for fit-content too but I will let you judge. Also
those comments apply to CSS tables too.


More information about the webkit-reviews mailing list