[webkit-reviews] review denied: [Bug 109712] [Chromium] Compositor is applying scroll offset using 'programmatic' API : [Attachment 192032] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 13:51:45 PST 2013


James Robinson <jamesr at chromium.org> has denied John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 109712: [Chromium] Compositor is applying scroll offset using
'programmatic' API
https://bugs.webkit.org/show_bug.cgi?id=109712

Attachment 192032: Patch
https://bugs.webkit.org/attachment.cgi?id=192032&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192032&action=review


> Source/WebCore/page/FrameView.cpp:1812
> +void FrameView::setScrollPosition(const IntPoint& scrollPoint, bool
isProgrammaticScroll)

The existing code that uses setScrollPosition has not needed this parameter.  I
don't think you should add it.


More information about the webkit-reviews mailing list