[webkit-reviews] review granted: [Bug 110839] run-perf-tests fails due to svn_revision not working on a pure git clone : [Attachment 192076] use --grep=foo rather than --grep foo

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 110839: run-perf-tests fails due to svn_revision not working on a pure git
clone
https://bugs.webkit.org/show_bug.cgi?id=110839

Attachment 192076: use --grep=foo rather than --grep foo
https://bugs.webkit.org/attachment.cgi?id=192076&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192076&action=review


> Tools/Scripts/webkitpy/common/checkout/scm/git.py:251
> +	   git_log = self._run_git(['log', '-1', '--grep=git-svn-id:',
self.find_checkout_root(path)])

You might add a comment about why we use grep= instead of the standard separate
arguments.  Or heck, we could even share these two calls in a helper function.