[webkit-reviews] review denied: [Bug 111728] Implement support for nullable types in the bindings generator : [Attachment 191992] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Peter Beverloo <peter at chromium.org>'s
request for review:
Bug 111728: Implement support for nullable types in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=111728

Attachment 191992: Patch
https://bugs.webkit.org/attachment.cgi?id=191992&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191992&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1051
> +	   if ($isNullable) {
> +	       push(@implContentInternals, "	if (isNull)\n");
> +	       push(@implContentInternals, "	    return
v8Null(info.GetIsolate());\n");
>	   }

I don't understand.  We basically assume that all attributes are nullable in
our implementation.  The way we implement non-nullable attributes is by never
returning null from the implementation.

I would have expected this patch to be an ASSERT that we don't return null from
non-nullable attributes.