[webkit-reviews] review granted: [Bug 109464] [CSS Shaders] Implement hue and saturation non-separable blend modes : [Attachment 191059] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 11:24:01 PST 2013


Dean Jackson <dino at apple.com> has granted Michelangelo De Simone
<michelangelo at webkit.org>'s request for review:
Bug 109464: [CSS Shaders] Implement hue and saturation non-separable blend
modes
https://bugs.webkit.org/show_bug.cgi?id=109464

Attachment 191059: Patch
https://bugs.webkit.org/attachment.cgi?id=191059&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191059&action=review


> Source/WebCore/ChangeLog:10
> +	       - css_Sat(C): returns the saturation for the color C
> +	       - css_SetSat(C, s): sets the saturation s on the color C
> +	       - css_SetSatHelper(Cmin, Cmid, Cmax, s): helper function for
css_SetSat

Why are you using "Sat" rather than "Saturation"? I guess we already did "Lum"
so it is consistent.


More information about the webkit-reviews mailing list