[webkit-reviews] review granted: [Bug 98168] Move side-effects on hover/active state out of hit-testing : [Attachment 191217] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 10:31:29 PST 2013


Julien Chaffraix <jchaffraix at webkit.org> has granted Mike West
<mkwst at chromium.org>'s request for review:
Bug 98168: Move side-effects on hover/active state out of hit-testing
https://bugs.webkit.org/show_bug.cgi?id=98168

Attachment 191217: Patch
https://bugs.webkit.org/attachment.cgi?id=191217&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191217&action=review


> Source/WebCore/dom/Document.cpp:5899
> +	   updateStyleIfNeeded();

This really looks like it should be some RAII pattern or else the next person
adding a return will skip updating the style.


More information about the webkit-reviews mailing list