[webkit-reviews] review requested: [Bug 111717] Web Inspector: [CodeMirror] set indentation size according to devtools settings : [Attachment 191982] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 09:47:07 PST 2013


Andrey Lushnikov <lushnikov at chromium.org> has asked  for review:
Bug 111717: Web Inspector: [CodeMirror] set indentation size according to
devtools settings
https://bugs.webkit.org/show_bug.cgi?id=111717

Attachment 191982: Patch
https://bugs.webkit.org/attachment.cgi?id=191982&action=review

------- Additional Comments from Andrey Lushnikov <lushnikov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191982&action=review


>> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:59
>> +	if (indent === WebInspector.TextUtils.Indent.TabCharacter) {
> 
> WebInspector.TextUtils.Indent is undefined

It was introduced here: https://bugs.webkit.org/show_bug.cgi?id=111715


More information about the webkit-reviews mailing list