[webkit-reviews] review denied: [Bug 111701] Basic child obscuration test for backgrounds : [Attachment 191961] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 111701: Basic child obscuration test for backgrounds
https://bugs.webkit.org/show_bug.cgi?id=111701

Attachment 191961: patch
https://bugs.webkit.org/attachment.cgi?id=191961&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191961&action=review


You should add a repaint test for this.

> Source/WebCore/rendering/RenderBox.cpp:1145
> +	   if (childBox->style()->visibility() != VISIBLE)
> +	       continue;
> +	   if (childBox->style()->position() != StaticPosition &&
childBox->containingBlock() != this)
> +	       continue;

What about transforms?