[webkit-reviews] review granted: [Bug 111094] [Qt] QWebSettings::clearMemoryCaches should clear JS garbage : [Attachment 192008] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 08:53:10 PST 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Arunprasad
<ArunPrasadR at nds.com>'s request for review:
Bug 111094: [Qt] QWebSettings::clearMemoryCaches should clear JS garbage
https://bugs.webkit.org/show_bug.cgi?id=111094

Attachment 192008: Patch
https://bugs.webkit.org/attachment.cgi?id=192008&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192008&action=review


> Source/WebKit/qt/Api/qwebsettings.cpp:818
> +    Frees up as much memory as possible by calling the JavaScript garbage
collector and cleaning all memory caches such
>      as page, object and font cache.

The first line should have been cut but this is a minor issue. I should have
told you earlier.
Thanks for fixing it, r=me


More information about the webkit-reviews mailing list