[webkit-reviews] review denied: [Bug 111094] [Qt] QWebSettings::clearMemoryCaches should clear JS garbage : [Attachment 191996] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 08:25:47 PST 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Arunprasad
<ArunPrasadR at nds.com>'s request for review:
Bug 111094: [Qt] QWebSettings::clearMemoryCaches should clear JS garbage
https://bugs.webkit.org/show_bug.cgi?id=111094

Attachment 191996: Patch
https://bugs.webkit.org/attachment.cgi?id=191996&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191996&action=review


> Source/WebKit/qt/Api/qwebsettings.cpp:817
> -    Frees up as much memory as possible by cleaning all memory caches such
> +    Frees up as much memory as possible by calling JavaScript Garbager
Collector, cleaning all memory caches such

Proper english please, the documentation is generated from this.
"Frees up as much memory as possible by calling the JavaScript garbage
collector and cleaning..."


More information about the webkit-reviews mailing list