[webkit-reviews] review denied: [Bug 111717] Web Inspector: [CodeMirror] set indentation size according to devtools settings : [Attachment 191982] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 08:07:31 PST 2013


Vsevolod Vlasov <vsevik at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 111717: Web Inspector: [CodeMirror] set indentation size according to
devtools settings
https://bugs.webkit.org/show_bug.cgi?id=111717

Attachment 191982: Patch
https://bugs.webkit.org/attachment.cgi?id=191982&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191982&action=review


> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:59
> +    if (indent === WebInspector.TextUtils.Indent.TabCharacter) {

WebInspector.TextUtils.Indent is undefined


More information about the webkit-reviews mailing list