[webkit-reviews] review denied: [Bug 111313] Web Inspector: [Elements] XSLT transformation result from the xml-stylesheet PI not rendered : [Attachment 191989] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 111313: Web Inspector: [Elements] XSLT transformation result from the
xml-stylesheet PI not rendered
https://bugs.webkit.org/show_bug.cgi?id=111313

Attachment 191989: Patch
https://bugs.webkit.org/attachment.cgi?id=191989&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191989&action=review


> Source/WebCore/dom/Document.cpp:4246
> +    InspectorInstrumentation::documentUpdated(ownerFrame,
ownerFrame->document());

I don't think you need to pass document here.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1686
> +    DocumentLoader* loader = frame->loader()->documentLoader();

I don't think this is needed.

> Source/WebCore/inspector/InspectorInstrumentation.h:1656
> +#if ENABLE(INSPECTOR)

Please add FAST_RETURN_IF_NO_FRONTENDS check here.