[webkit-reviews] review denied: [Bug 111703] Web Inspector: provide reasons why a layer was composited in the LayerTreeAgent : [Attachment 191987] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 111703: Web Inspector: provide reasons why a layer was composited in the
LayerTreeAgent
https://bugs.webkit.org/show_bug.cgi?id=111703

Attachment 191987: Patch
https://bugs.webkit.org/attachment.cgi?id=191987&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191987&action=review


> Source/WebCore/inspector/Inspector.json:3708
> +		       { "name": "reasonsMask", "type": "integer",
"description": "The reasons why the layer was composited." }

I don't think exposing the raw mask is safe and exposes internal WebCore data
that might not be stable. There are no guarantees someone won't add an item in
the middle later. Returning an array of values defined in the protocol as an
enum is the safest option. That way the clients don't need internal knowledge
of WebCore and everything is defined in the protocol. That would encourage
anyone adding reasons in the future to also extend the protocol enums.