[webkit-reviews] review denied: [Bug 111350] [Shadow DOM][Mac] Linking error for DOMCSSHostRule : [Attachment 191923] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 05:05:42 PST 2013


Timothy Hatcher <timothy at apple.com> has denied	review:
Bug 111350: [Shadow DOM][Mac] Linking error for DOMCSSHostRule
https://bugs.webkit.org/show_bug.cgi?id=111350

Attachment 191923: Patch
https://bugs.webkit.org/attachment.cgi?id=191923&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191923&action=review


> Source/WebCore/bindings/objc/PublicDOMInterfaces.h:924
> +#if defined(ENABLE_SHADOW_DOM) && ENABLE_SHADOW_DOM
> + at interface DOMCSSHostRule : DOMCSSRule WEBKIT_VERSION_1_3
> + at property(readonly, retain) DOMCSSRuleList *cssRules;
> +- (unsigned)insertRule:(NSString *)rule index:(unsigned)index
AVAILABLE_WEBKIT_VERSION_3_0_AND_LATER;
> +- (void)deleteRule:(unsigned)index;
> + at end
> +#endif

This should not be added to PublicDOMInterfaces.h at this time. It should be
SPI (in PrivateHeaders) for now.


More information about the webkit-reviews mailing list