[webkit-reviews] review denied: [Bug 111697] Web Inspector: Flame Chart. Stick item color to the function. : [Attachment 191949] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 04:22:40 PST 2013


Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 111697: Web Inspector: Flame Chart. Stick item color to the function.
https://bugs.webkit.org/show_bug.cgi?id=111697

Attachment 191949: Patch
https://bugs.webkit.org/attachment.cgi?id=191949&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191949&action=review


> Source/WebCore/inspector/front-end/FlameChart.js:181
> +	       var lightness = this._highlightedNode === node ? 33 : 67;

The color isn't restored when selected node changes. r- for this


More information about the webkit-reviews mailing list