[webkit-reviews] review denied: [Bug 105180] [GTK] When the WebProcess crashes, a signal should be emitted : [Attachment 191675] process-crashed.diff

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 105180: [GTK] When the WebProcess crashes, a signal should be emitted
https://bugs.webkit.org/show_bug.cgi?id=105180

Attachment 191675: process-crashed.diff
https://bugs.webkit.org/attachment.cgi?id=191675&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191675&action=review


After looking at the implementation I've changed my mind, and I think it's
better to move the signal to the web view. It will make the api easier to use.
And for the download case, we can always add the signal to WebKitDownload, to
notify the download that the web process crashed.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:838
> +void webkitWebContextWebProcessCrashed(WebKitWebContext* context)
> +{
> +    g_signal_emit(context, signals[WEB_PROCESS_CRASHED], 0);
> +}

This is very problematic in the end, because we are emitting the signal in the
context but for every web page.