[webkit-reviews] review granted: [Bug 104268] [chromium] expose UserGestureIndicator::Token via WebKit API so PPAPI plugins can correctly consume it : [Attachment 191680] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted
jochen at chromium.org's request for review:
Bug 104268: [chromium] expose UserGestureIndicator::Token via WebKit API so
PPAPI plugins can correctly consume it
https://bugs.webkit.org/show_bug.cgi?id=104268

Attachment 191680: Patch
https://bugs.webkit.org/attachment.cgi?id=191680&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191680&action=review


> Source/WebKit/chromium/public/WebScopedUserGesture.h:52
> +// Instead, obtain the current WebUserGestureToken from the WebFrame, and
use

nit: This comment seems out-of-date.

> Source/WebKit/chromium/src/WebScopedUserGesture.cpp:47
> +	   m_indicator.reset(new
WebCore::UserGestureIndicator(static_cast<WebCore::UserGestureToken*>(token)));


nit: The static_cast is really needed?