[webkit-reviews] review denied: [Bug 111682] [chromium] adjust conditions for compositing fixed-position layers : [Attachment 191918] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 6 23:20:19 PST 2013
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 111682: [chromium] adjust conditions for compositing fixed-position layers
https://bugs.webkit.org/show_bug.cgi?id=111682
Attachment 191918: Patch
https://bugs.webkit.org/attachment.cgi?id=191918&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
Please don't put PLATFORM #ifdefs in cross-platform code. You should make it
conditional on a Setting, or make an #ifdef that is more descriptive.
More information about the webkit-reviews
mailing list