[webkit-reviews] review denied: [Bug 111620] [GTK][WK2] Add webkit_uri_request_set_uri to WebKit2 GTK+ API : [Attachment 191825] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 111620: [GTK][WK2] Add webkit_uri_request_set_uri to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111620

Attachment 191825: Patch
https://bugs.webkit.org/attachment.cgi?id=191825&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Thanks for the patch, but this has already been added, see patch in bug #83681,
it hasn't landed in trunk yet because it's waiting for a WebKit2 owner, but
landed in the stable branch already. In any case your patch has some issues,
you are allowing the API to modify a construct only property, you should change
the property to not be construct only, and use webkit_uri_request_set_uri()in
the GObject setter too, emitting the notify signal when it changes.