[webkit-reviews] review denied: [Bug 111680] Web Inspector: Add shortcut for running a snippet. : [Attachment 191915] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 111680: Web Inspector: Add shortcut for running a snippet.
https://bugs.webkit.org/show_bug.cgi?id=111680

Attachment 191915: Patch
https://bugs.webkit.org/attachment.cgi?id=191915&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191915&action=review


> Source/WebCore/inspector/front-end/SnippetJavaScriptSourceFrame.js:46
> +    var runSnippetShortcutDescriptor =
WebInspector.KeyboardShortcut.makeDescriptor(WebInspector.KeyboardShortcut.Keys
.Enter, WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta)

Eclipse uses Ctrl+F11, Ctrl+F10 idea.

> Source/WebCore/inspector/front-end/SnippetJavaScriptSourceFrame.js:72
> +    _onKeyDown: function(event)

I've seen this code. Should it be moved to View.js with corresponding
registerShortcut(key, modifier, handler) ? I even thing handler should be
unbound for the sake of performance.