[webkit-reviews] review granted: [Bug 110839] run-perf-tests fails due to svn_revision not working on a pure git clone : [Attachment 191898] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 110839: run-perf-tests fails due to svn_revision not working on a pure git
clone
https://bugs.webkit.org/show_bug.cgi?id=110839

Attachment 191898: Patch
https://bugs.webkit.org/attachment.cgi?id=191898&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191898&action=review


LGTM.  Thank you for taking this on.

> Tools/Scripts/webkitpy/common/checkout/scm/scm.py:170
> +	   """Returns the latest svn revision found in the checkout."""

This may be the first time I've found docstrings helpful. :p

> Tools/Scripts/webkitpy/common/system/outputcapture.py:32
> +import unittest  # Don't use unittest2 here as the autoinstaller may not
have it yet.

Assuming you tested this with py2.5/2.7 sgtm.