[webkit-reviews] review granted: [Bug 111661] [Chromium] Fix byte ordering bugs reading back WebGL canvases' content on Android : [Attachment 191888] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 111661: [Chromium] Fix byte ordering bugs reading back WebGL canvases'
content on Android
https://bugs.webkit.org/show_bug.cgi?id=111661

Attachment 191888: Patch
https://bugs.webkit.org/attachment.cgi?id=191888&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191888&action=review


> Source/WebCore/platform/chromium/support/GraphicsContext3DChromium.cpp:533
> +#if (SK_R32_SHIFT == 16) && !SK_B32_SHIFT

this is the same check as
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/S
ource/WebKit/chromium/src/WebViewImpl.cpp&q=WebViewImpl.cpp&sq=package:chromium
&type=cs&l=1885, although it's written the other way 'round.  Any chance of
getting something clearer?