[webkit-reviews] review granted: [Bug 111382] [V8] Use implicit references instead of object groups to keep registered MutationObservers alive : [Attachment 191633] WIP: two-phase vector approach, mark 2

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 111382: [V8] Use implicit references instead of object groups to keep
registered MutationObservers alive
https://bugs.webkit.org/show_bug.cgi?id=111382

Attachment 191633: WIP: two-phase vector approach, mark 2
https://bugs.webkit.org/attachment.cgi?id=191633&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191633&action=review


> Source/WebCore/bindings/v8/V8GCController.cpp:149
> +	       {

Why have these { } ?

> Source/WebCore/bindings/v8/V8GCController.cpp:173
> +	      
v8::V8::AddImplicitReferences(v8::Persistent<v8::Object>::Cast(parentWrapper),
children.data(), children.size());

Should we ASSERT that parentWrapper is really an object before casting it? 
(Maybe the cast does that assert for us?

It's a bit odd to have this cast here.	I guess AddImplicitReferences needs an
object as the first argument but AddObjectGroup can deal with values?