[webkit-reviews] review granted: [Bug 111459] IndexedDB: Use WeakPtr for Factory-to-BackingStore reference : [Attachment 191803] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 111459: IndexedDB: Use WeakPtr for Factory-to-BackingStore reference
https://bugs.webkit.org/show_bug.cgi?id=111459

Attachment 191803: Patch
https://bugs.webkit.org/attachment.cgi?id=191803&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191803&action=review


We could also let you register a callback with WeakPtr to be notified when it
gets cleared, but we probably don't need to tech to that level yet.

> Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp:45
> +template<typename K, typename M>
> +static void cleanWeakMap(HashMap<K, WeakPtr<M> >& map)

This seems like a pretty general-purpose function for this file.  I wonder if
we should move it to WTF somewhere...  Maybe this pattern is obscure enough
that it's fine to keep it here.