[webkit-reviews] review granted: [Bug 107618] Fix painting phases for composited scrolling : [Attachment 191745] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 14:07:43 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted vollick at chromium.org's
request for review:
Bug 107618: Fix painting phases for composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=107618

Attachment 191745: Patch
https://bugs.webkit.org/attachment.cgi?id=191745&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191745&action=review


> Source/WebCore/rendering/RenderLayer.cpp:3662
> +    bool shouldPaintOutline = isSelfPaintingLayer &&
!isPaintingOverlayScrollbars
> +	   && ((isPaintingScrollingContent && isPaintingCompositedBackground)
> +	   || (!isPaintingScrollingContent && isPaintingCompositedForeground));


I think this deserves a comment. It also means that focus rings will end up
layering differently with composited scrolling, right?


More information about the webkit-reviews mailing list