[webkit-reviews] review granted: [Bug 111592] fast/css/hover-update.html is flaky : [Attachment 191790] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 6 10:46:36 PST 2013
Ryosuke Niwa <rniwa at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 111592: fast/css/hover-update.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=111592
Attachment 191790: Patch
https://bugs.webkit.org/attachment.cgi?id=191790&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191790&action=review
Let's try this.
> LayoutTests/fast/css/hover-update.html:31
> + if (timeSinceStartedCheckingMs < 200 &&
window.getComputedStyle(document.getElementById('b'), null).backgroundColor !=
expectedBackgroundColor) {
> + setTimeout(finish, 10);
> + return;
> + }
> +
shouldBeEqualToString("window.getComputedStyle(document.getElementById('b'),
null).backgroundColor", expectedBackgroundColor);
Nit: It seems like window. is unnecessary?
More information about the webkit-reviews
mailing list