[webkit-reviews] review granted: [Bug 106558] [Windows] Compile fix. : [Attachment 182340] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 6 09:15:00 PST 2013
Darin Adler <darin at apple.com> has granted peavo at outlook.com's request for
review:
Bug 106558: [Windows] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=106558
Attachment 182340: Patch
https://bugs.webkit.org/attachment.cgi?id=182340&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182340&action=review
Fine to add these includes. But none of these includes should be inside #if.
They are all safe to do on non-Windows platforms so they should be
unconditional.
> Source/WebCore/platform/network/cf/AuthenticationCF.cpp:39
> +#endif
> // This header must come before all other CFNetwork headers to work around a
CFNetwork bug. It can
Missing blank line here.
More information about the webkit-reviews
mailing list