[webkit-reviews] review granted: [Bug 101346] No condition present to check if Compressed Texture S3TC extension support exists : [Attachment 176808] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 09:04:17 PST 2013


Darin Adler <darin at apple.com> has granted akaushik at rim.com's request for
review:
Bug 101346: No condition present to check if Compressed Texture S3TC extension
support exists
https://bugs.webkit.org/show_bug.cgi?id=101346

Attachment 176808: Patch
https://bugs.webkit.org/attachment.cgi?id=176808&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176808&action=review


> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2382
> +    if (equalIgnoringCase(name, "WEBKIT_WEBGL_compressed_texture_s3tc")
> +	   && WebGLCompressedTextureS3TC::supported(this)) {

Normally we’d just put this on one line.


More information about the webkit-reviews mailing list